Skip to content

Feature: Add Partition and Balance to mesh handle#2241

Merged
spenke91 merged 9 commits intomainfrom
new-handle-partition-and-balance
Apr 1, 2026
Merged

Feature: Add Partition and Balance to mesh handle#2241
spenke91 merged 9 commits intomainfrom
new-handle-partition-and-balance

Conversation

@lenaploetzke
Copy link
Copy Markdown
Collaborator

Describe your changes here:
Closes #2117. This replaces #2116 where something got messed up because i changed the location of a file...

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation. Make sure to add a file documentation for each file!
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.
  • The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
  • Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the scripts/internal/find_all_source_files.sh to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026

Codecov Report

❌ Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.50%. Comparing base (c1a2993) to head (a602e25).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
mesh_handle/mesh.hxx 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2241      +/-   ##
==========================================
+ Coverage   78.45%   78.50%   +0.05%     
==========================================
  Files         115      115              
  Lines       19184    19198      +14     
==========================================
+ Hits        15050    15071      +21     
+ Misses       4134     4127       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@spenke91 spenke91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! I only have minor remarks -- and in fact none of them is about the actual code, just comments on comments 😆

@spenke91 spenke91 assigned lenaploetzke and unassigned spenke91 Mar 26, 2026
lenaploetzke and others added 3 commits March 26, 2026 11:31
Co-authored-by: spenke91 <thomas.spenke@dlr.de>
…/t8code into new-handle-partition-and-balance
@lenaploetzke lenaploetzke requested a review from spenke91 March 26, 2026 10:45
spenke91
spenke91 previously approved these changes Mar 26, 2026
Copy link
Copy Markdown
Collaborator

@spenke91 spenke91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@spenke91 spenke91 assigned lenaploetzke and unassigned spenke91 Mar 26, 2026
Base automatically changed from handle_add-adapt_function to main March 30, 2026 13:18
@sandro-elsweijer sandro-elsweijer dismissed spenke91’s stale review March 30, 2026 13:18

The base branch was changed.

@lenaploetzke lenaploetzke assigned spenke91 and unassigned lenaploetzke and spenke91 Apr 1, 2026
Copy link
Copy Markdown
Collaborator

@spenke91 spenke91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new test you added looks good, thanks,

@spenke91 spenke91 assigned lenaploetzke and unassigned spenke91 Apr 1, 2026
@spenke91 spenke91 added this pull request to the merge queue Apr 1, 2026
Merged via the queue into main with commit 01c1f92 Apr 1, 2026
26 checks passed
@spenke91 spenke91 deleted the new-handle-partition-and-balance branch April 1, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Add Partition and Balance to mesh handle

2 participants